[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/kword/part
From:       Thomas Zander <zander () kde ! org>
Date:       2010-10-23 9:03:34
Message-ID: 201010231103.34922.zander () kde ! org
[Download RAW message or body]

On Saturday 23. October 2010 01.27.08 Jos van den Oever wrote:
> On Friday, October 22, 2010 14:24:24 pm Thomas Zander wrote:
> > On Wednesday 20. October 2010 09.29.45 Jos van den Oever wrote:
> > > SVN commit 1187692 by vandenoever:
> > > 
> > > Do not write out text:page-sequence.
> > > 
> > > It is only allowed when no text elements like text:p or text:h are
> > > written. KOffice does not seem to use text:page-sequence at all.
> > 
> > How do you come to the conclusion text:p / text:h are mutually exclusive
> > with text:page-sequence? The spec doesn't seem to mention it as far as I
> > can see.
> > 
> > The page-sequence is required to write out pages that are user-inserted.
> > This includes the usecase where there is no mainTextFrame, but there are
> > other usecases too.
> > 
> > Can you give some insight why the two types of elements are mutually
> > exclusive? I think its a bug (or missing ODF feature) if thats really the
> > case.
> 
> The Relax NG is clear. The reason is that p and h are flow based, that is
> text can flow to another page. text:page-sequence implies that your
> document consists of separately defined pages, i.e. no flowing that causes
> new pages.

Yes, thats the usecase I referred to above. Where there is no mainTextFrame.
 
> So indeed it was a bug, but this commit fixed it. To fix KWord in agreement
> with the spec and be able to insert user defined pages, you will have to
> define a series of pages with fixed frames. If you want to implement this,
> you are welcome, but please note that developing support for this would be
> such a huge change that you'd need to do it in a separate branch.

That already works just fine, and has for quite some time. Try it by not having 
a main text frameset. (checkbox in startup dialog, custom doc)
The removal of the code that writes out the pages makes that stop working 
though, so your fix to remove code sounds wrong to me.

A better fix would be to not write out the page-sequence when there is a body 
text.

-- 
Thomas Zander
[prev in list] [next in list] [prev in thread] [next in thread]