[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/plugins/chartshape
From:       Johannes Simon <johannes.simon () gmail ! com>
Date:       2010-10-21 20:49:22
Message-ID: D3CDAABF-469A-47C9-9E26-4FCB3BCF51E0 () gmail ! com
[Download RAW message or body]

The fix looks good to me. One small thing though: Using the ignoreCellRanges "flag" was a bit of experimental and meant to work around OOo producing invalid cell-regions, specifically the plot area's chart:cell-range-address contained a wrong table name (in some rare cases). I "removed" it again because we should rather obey what the ODF document dictates us, if it says "use this part of the internal table" then we should do that. I'd like to keep the workarounds to a minimum, so what was the reason here you put it back in? If a document didn't load correctly because it contained invalid cell regions, then we should check if the problem is limited to a certain version of OOo.

Am 20.10.2010 um 17:34 schrieb Björn Breitmeyer:

> SVN commit 1187868 by breitmeyer:
> 
> Fixed loading of cell regions that contain lists of regions
> 
<snip>
> --- trunk/koffice/plugins/chartshape/ChartProxyModel.cpp #1187867:1187868
> @@ -390,7 +390,7 @@
>     Q_ASSERT( d->isLoading );
> 
>     OdfLoadingHelper *helper = (OdfLoadingHelper*)context.sharedData( OdfLoadingHelperId );
> -    bool ignoreCellRanges = false;
> +    bool ignoreCellRanges = helper->chartUsesInternalModelOnly;
> // Some OOo documents save incorrect cell ranges. For those this fix was intended.
> // Find out which documents exactly and only use fix for as few cases as possible.
> #if 0


[prev in list] [next in list] [prev in thread] [next in thread]