[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/messagelist/core
From:       Tobias Koenig <tokoe () kde ! org>
Date:       2010-10-16 20:45:58
Message-ID: 20101016204558.7C1A7AC896 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1186545 by tokoe:

Use member initialization


 M  +0 -5      item.cpp  
 M  +8 -1      item_p.h  
 M  +5 -4      messageitem.cpp  


--- trunk/KDE/kdepim/messagelist/core/item.cpp #1186544:1186545
@@ -34,11 +34,6 @@
   : d( new ItemPrivate( this ) )
 {
   d->mType = type;
-  d->mChildItems = 0;
-  d->mParent = 0;
-  d->mThisItemIndexGuess = 0;
-  d->mIsViewable = false;
-  d->mInitialExpandStatus = NoExpandNeeded;
 }
 
 Item::~Item()
--- trunk/KDE/kdepim/messagelist/core/item_p.h #1186544:1186545
@@ -43,7 +43,14 @@
 {
 public:
   ItemPrivate( Item *owner )
-    : q( owner ) { }
+    : q( owner ),
+      mChildItems( 0 ),
+      mParent( 0 ),
+      mThisItemIndexGuess( 0 ),
+      mIsViewable( false ),
+      mInitialExpandStatus( Item::NoExpandNeeded )
+  {
+  }
 
   /**
    * Implements "in the middle" insertions of child items.
--- trunk/KDE/kdepim/messagelist/core/messageitem.cpp #1186544:1186545
@@ -193,7 +193,11 @@
 QFont MessageItem::Private::mFontToDoMessage;
 
 MessageItem::Private::Private()
-  : mAnnotationStateChecked( false ), mTagList( 0 )
+  : mThreadingStatus( MessageItem::ParentMissing ),
+    mUniqueId( 0 ),
+    mAboutToBeRemoved( false ),
+    mAnnotationStateChecked( false ),
+    mTagList( 0 )
 {
 }
 
@@ -287,9 +291,6 @@
 MessageItem::MessageItem()
   : Item( Message ), ModelInvariantIndex(), d( new Private )
 {
-  d->mThreadingStatus = MessageItem::ParentMissing;
-  d->mAboutToBeRemoved = false;
-  d->mUniqueId = 0;
 }
 
 MessageItem::~MessageItem()
[prev in list] [next in list] [prev in thread] [next in thread]