[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeedu/marble/src/lib/graphicsview
From:       Dennis Nienhüser <earthwings () gentoo ! org>
Date:       2010-10-11 21:35:52
Message-ID: 20101011213552.407DAAC896 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1184936 by nienhueser:

valgrind: members not initialized, possibly trying to delete random memory.

 M  +11 -0     WidgetGraphicsItem.cpp  
 M  +2 -5      WidgetGraphicsItem_p.h  


--- trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.cpp #1184935:1184936
@@ -24,6 +24,17 @@
 
 using namespace Marble;
 
+WidgetGraphicsItemPrivate::WidgetGraphicsItemPrivate() :
+        m_widget(0), m_marbleWidget(0)
+{
+    // nothing to do
+}
+
+WidgetGraphicsItemPrivate::~WidgetGraphicsItemPrivate()
+{
+    delete m_widget;
+}
+
 WidgetGraphicsItem::WidgetGraphicsItem( MarbleGraphicsItem *parent )
     : ScreenGraphicsItem( parent ),
       d( new WidgetGraphicsItemPrivate() )
--- trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem_p.h #1184935:1184936
@@ -23,12 +23,9 @@
 class WidgetGraphicsItemPrivate
 {
  public:
-    WidgetGraphicsItemPrivate() {
-    }
+    WidgetGraphicsItemPrivate();
     
-    ~WidgetGraphicsItemPrivate() {
-        delete m_widget;
-    }
+    ~WidgetGraphicsItemPrivate();
     
     QWidget *m_widget;
     QWidget *m_marbleWidget;
[prev in list] [next in list] [prev in thread] [next in thread]