[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kpresenter/part
From:       Jean-Nicolas Artaud <jeannicolasartaud () gmail ! com>
Date:       2010-10-11 19:16:49
Message-ID: 20101011191649.61B9BAC7E4 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1184906 by artaud:

* Remove an useless move command.


 M  +7 -7      KPrViewModeSlidesSorter.cpp  


--- trunk/koffice/kpresenter/part/KPrViewModeSlidesSorter.cpp #1184905:1184906
@@ -230,16 +230,12 @@
     }
 
     if (oldIndex != newIndex) {
-        if (newIndex <= 0) {
-            // First page
-            m_viewModeSlidesSorter->movePage(oldIndex, 0);
-            m_viewModeSlidesSorter->movePage(0, 1);
-        } else if (oldIndex > newIndex) {
+        if (oldIndex > newIndex) {
             m_viewModeSlidesSorter->movePage(oldIndex, newIndex - 1);
         } else {
-            // Nominal case
             m_viewModeSlidesSorter->movePage(oldIndex, newIndex);
         }
+
         QListWidgetItem *sourceItem = takeItem(oldIndex);
         insertItem(newIndex, sourceItem);
         // This selection helps the user
@@ -308,10 +304,14 @@
     KoPAPageBase * page = 0;
     KoPAPageBase * pageAfter = 0;
 
+    if (pageNumber >= 0) {
     page = m_view->kopaDocument()->pageByIndex(pageNumber,false);
+    }
+    if (pageAfterNumber >= 0) {
     pageAfter = m_view->kopaDocument()->pageByIndex(pageAfterNumber,false);
+    }
 
-    if (page && pageAfter) {
+    if (page) {
         KoPAPageMoveCommand *command = new KoPAPageMoveCommand( \
m_view->kopaDocument(), page, pageAfter );  m_view->kopaDocument()->addCommand( \
command );  }


[prev in list] [next in list] [prev in thread] [next in thread]