[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/pim/kblogger/src
From:       David Faure <faure () kde ! org>
Date:       2010-10-06 21:52:49
Message-ID: 20101006215249.AE902AC897 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1183302 by dfaure:

Compile with strict iterators (and document some non-optimal code paths)


 M  +4 -4      media/importmediawidget.cpp  
 M  +3 -2      media/medialistwidget.cpp  
 M  +3 -2      post/postslist.cpp  
 M  +2 -2      profiles/profilelist.cpp  


--- trunk/playground/pim/kblogger/src/media/importmediawidget.cpp #1183301:1183302
@@ -53,8 +53,8 @@
 {
     kDebug();
     // clean things up
-    QList<QTreeWidgetItem*>::ConstIterator it = treeItemList.begin();
-    QList<QTreeWidgetItem*>::ConstIterator end = treeItemList.end();
+    QList<QTreeWidgetItem*>::ConstIterator it = treeItemList.constBegin();
+    QList<QTreeWidgetItem*>::ConstIterator end = treeItemList.constEnd();
     for( ; it != end; it++ ){
         mediaTreeWidget->removeItemWidget( *it, 0 );
         delete( *it );
@@ -127,8 +127,8 @@
 {
     kDebug();
     //Download images
-    QList<QTreeWidgetItem*>::ConstIterator it = treeItemList.begin();
-    QList<QTreeWidgetItem*>::ConstIterator end = treeItemList.end();
+    QList<QTreeWidgetItem*>::ConstIterator it = treeItemList.constBegin();
+    QList<QTreeWidgetItem*>::ConstIterator end = treeItemList.constEnd();
     for( ; it != end; it++ ){
         createMediaFromUrl( *it );
     }
--- trunk/playground/pim/kblogger/src/media/medialistwidget.cpp #1183301:1183302
@@ -183,13 +183,14 @@
 MediaList::~MediaList()
 {
     kDebug();
-    QList<QTreeWidgetItem*> treeList = mMediaMap.keys();
+    // Slow! Iterate over the map directly!
+    const QList<QTreeWidgetItem*> treeList = mMediaMap.keys();
     QList<QTreeWidgetItem*>::ConstIterator it = treeList.begin();
     QList<QTreeWidgetItem*>::ConstIterator end = treeList.end();
     for( ; it != end; it++ ){
         //NOTE QTreeWidgetItem will be deleted automatically
         //delete *it is not required!
-        delete mMediaMap[ (*it) ];
+        delete mMediaMap.value( (*it) );
     }
 }
 
--- trunk/playground/pim/kblogger/src/post/postslist.cpp #1183301:1183302
@@ -84,11 +84,12 @@
 PostsList::~PostsList()
 {
     kDebug();
-    QList<QTreeWidgetItem*> treeList = mPostsMap.keys();
+    // Slow! Iterate over the map, instead.
+    const QList<QTreeWidgetItem*> treeList = mPostsMap.keys();
     QList<QTreeWidgetItem*>::ConstIterator it = treeList.begin();
     QList<QTreeWidgetItem*>::ConstIterator end = treeList.end();
     for( ; it != end; it++ ){
-        delete mPostsMap[ (*it) ];
+        delete mPostsMap.value( (*it) );
         delete ( *it );
     }
 }
--- trunk/playground/pim/kblogger/src/profiles/profilelist.cpp #1183301:1183302
@@ -128,8 +128,8 @@
     QString entriesFilename = QString(account).prepend(DIR_TO_SAVE_ENTRIES);
     QStringList list;
     list << "-sent" << "-local" << "-trash";
-    QStringList::ConstIterator it = list.begin();
-    QStringList::ConstIterator end = list.end();
+    QStringList::ConstIterator it = list.constBegin();
+    QStringList::ConstIterator end = list.constEnd();
     for( ; it != end; it++ ){
         QString entryFilenameToRemove( entriesFilename );
         entryFilenameToRemove.append( *it );
[prev in list] [next in list] [prev in thread] [next in thread]