[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/kdepim/enterprise/kdepim/kmail
From:       Allen Winter <winter () kde ! org>
Date:       2010-10-04 0:36:33
Message-ID: 20101004003633.1218CAC88C () svn ! kde ! org
[Download RAW message or body]

SVN commit 1182256 by winterz:

when printing debug messages in the mailLossDebug mode, do not attempt
to access the folder's prettyURL().  this is because prettyURL() searches
up the folder's ancestry while trying to discover its family name :)

problem is: on quit, the ancestor nodes might already be invalidated due
to the order they were destroyed.

thus, we use folder->idString() instead in the print.. it ain't pretty, but it's safe
and does the job.

MERGE: none, tag



 M  +4 -2      kmfoldercachedimap.cpp  


--- branches/kdepim/enterprise/kdepim/kmail/kmfoldercachedimap.cpp #1182255:1182256
@@ -358,7 +358,8 @@
       configGroup.writeEntry( "UIDSDeletedSinceLastSync", uidstrings );
       if ( GlobalSettings::self()->mailLossDebug() ) {
         if ( folder() ) {
-          kdDebug( 5006 ) << "WRITING OUT UIDSDeletedSinceLastSync in: " << \
folder()->prettyURL( ) << endl << uidstrings << endl; +          // do NOT use \
folder()->prettyURL as that is too dangerous at quitting time +          kdDebug( \
5006 ) << "WRITING OUT UIDSDeletedSinceLastSync in: " << folder()->idString( ) << \
endl << uidstrings << endl;  } else {
           kdDebug( 5006 ) << "CANNOT WRITE OUT UIDSDeletedSinceLastSync since \
folder() is NULL" << endl;  }
@@ -472,7 +473,8 @@
   }
   if ( GlobalSettings::self()->mailLossDebug() ) {
     if ( folder() ) {
-      kdDebug(5006) << "Writing out UID cache lastuid: " << lastUid()  << " in: " << \
folder()->prettyURL() << endl; +      // do NOT use folder()->prettyURL as that is \
too dangerous at quitting time +      kdDebug(5006) << "Writing out UID cache \
lastuid: " << lastUid()  << " in: " << folder()->idString() << endl;  } else {
       kdDebug(5006) << "CANNOT WRITE OUT UID cache lastuid since folder() is NULL" \
<< endl;  }


[prev in list] [next in list] [prev in thread] [next in thread]