[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/krita/plugins/paintops
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-10-02 12:26:01
Message-ID: 20101002122601.AFA05AC891 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1181837 by dkazakov:

Removed excessive cropping of the destination rect

Actually, this cropping must be encapsulated inside KisPainter and not
be spread like a "global cropping variable" throughout all the code.

This crop caused bugs in the DuplicateOp.
BUG:253014


 M  +0 -4      complexop/kis_complexop.cpp  
 M  +0 -4      defaultpaintops/duplicate/kis_duplicateop.cpp  
 M  +0 -3      filterop/kis_filterop.cpp  


--- trunk/koffice/krita/plugins/paintops/complexop/kis_complexop.cpp #1181836:1181837
@@ -110,10 +110,6 @@
     QRect dabRect = QRect(0, 0, brush->maskWidth(scale, 0.0), brush->maskHeight(scale, 0.0));
     QRect dstRect = QRect(x, y, dabRect.width(), dabRect.height());
 
-    if (painter()->bounds().isValid()) {
-        dstRect &= painter()->bounds();
-    }
-
     if (dstRect.isNull() || dstRect.isEmpty() || !dstRect.isValid()) return 1;
 
     qint32 sx = dstRect.x() - x;
--- trunk/koffice/krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp #1181836:1181837
@@ -299,10 +299,6 @@
 
     QRect dstRect = QRect(x, y, dab->bounds().width(), dab->bounds().height());
 
-    if (painter()->bounds().isValid()) {
-        dstRect &= painter()->bounds();
-    }
-
     if (dstRect.isNull() || dstRect.isEmpty() || !dstRect.isValid()) return 1.0;
 
     qint32 sx = dstRect.x() - x;
--- trunk/koffice/krita/plugins/paintops/filterop/kis_filterop.cpp #1181836:1181837
@@ -143,9 +143,6 @@
     QRect dabRect = QRect(0, 0, maskWidth, maskHeight);
     QRect dstRect = QRect(x, y, dabRect.width(), dabRect.height());
 
-    if (painter()->bounds().isValid()) {
-        dstRect &= painter()->bounds();
-    }
     if (dstRect.isNull() || dstRect.isEmpty() || !dstRect.isValid()) return 1.0;
 
     qint32 sx = dstRect.x() - x;
[prev in list] [next in list] [prev in thread] [next in thread]