[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/cmake/modules
From:       Colin Guthrie <cguthrie () mandriva ! org>
Date:       2010-09-30 20:22:45
Message-ID: 4CA4F195.60006 () mandriva ! org
[Download RAW message or body]

'Twas brillig, and Alexander Neundorf at 30/09/10 20:30 did gyre and gimble:
> On Thursday 30 September 2010, Colin Guthrie wrote:
>> SVN commit 1181320 by cguthrie:
>>
>> Make the PulseAudio version check regexp tolerant to extra fluff at the end
>> of the major.minor.micro
> 
> What extra fluff, how does that look like ?

Basically it takes the form output by the git-version-gen script
(similar to the one in the kernel I think), so on one build here for me
it say e.g.:

#define pa_get_headers_version() ("0.9.19-562-g395da")

If my git tree was dirty it would put that in there too. In Mandriva I
do something similar so as to identify which build users had installed
when they submitted bug reports etc.

So the regexp just swallows up the extra junk now.

I guess it would be better to process the defines for the major, minor
and micro, but, hey, the regexp should remain pretty reliable :)

Col


-- 

Colin Guthrie
cguthrie(at)mandriva.org
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]
[prev in list] [next in list] [prev in thread] [next in thread]