[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/libs/pigment
From:       Cyrille Berger <cyb () lepi ! org>
Date:       2010-09-26 11:39:41
Message-ID: 20100926113941.55044AC857 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1179888 by berger:

Fix HSV transformation for brushes color does not work with non-rgb color spaces

BUG:251453


 M  +2 -0      KoColorTransformation.cpp  
 M  +15 -0     KoFallBackColorTransformation.cpp  
 M  +3 -0      KoFallBackColorTransformation.h  
 M  +8 -0      tests/CMakeLists.txt  
 A             tests/TestFallBackColorTransformation.cpp   [License: UNKNOWN]
 A             tests/TestFallBackColorTransformation.h   [License: GPL (v2+)]


--- trunk/koffice/libs/pigment/KoColorTransformation.cpp #1179887:1179888
@@ -31,6 +31,7 @@
 int KoColorTransformation::parameterId(const QString& name) const
 {
     Q_UNUSED(name);
+    qFatal("No parameter for this transformation");
     return -1;
 }
 
@@ -38,6 +39,7 @@
 {
   Q_UNUSED(id);
   Q_UNUSED(parameter);
+  qFatal("No parameter for this transformation");
 }
 
 void KoColorTransformation::setParameters(const QHash<QString, QVariant> & \
                parameters)
--- trunk/koffice/libs/pigment/KoFallBackColorTransformation.cpp #1179887:1179888
@@ -92,3 +92,18 @@
     d->colorTransformation->transform(d->buff, d->buff, nPixels);
     d->fallBackToCs->transform(d->buff, dst, nPixels);
 }
+
+QList<QString> KoFallBackColorTransformation::parameters() const
+{
+  return d->colorTransformation->parameters();
+}
+
+int KoFallBackColorTransformation::parameterId(const QString& name) const
+{
+  return d->colorTransformation->parameterId(name);
+}
+
+void KoFallBackColorTransformation::setParameter(int id, const QVariant& parameter)
+{
+  d->colorTransformation->setParameter(id, parameter);
+}
--- trunk/koffice/libs/pigment/KoFallBackColorTransformation.h #1179887:1179888
@@ -61,6 +61,9 @@
     KoFallBackColorTransformation(KoColorConversionTransformation* _csToFallBack, \
KoColorConversionTransformation* _fallBackToCs, KoColorTransformation* _transfo);  \
                virtual ~KoFallBackColorTransformation();
     virtual void transform(const quint8 *src, quint8 *dst, qint32 nPixels) const;
+    virtual QList<QString> parameters() const;
+    virtual int parameterId(const QString& name) const;
+    virtual void setParameter(int id, const QVariant& parameter);
 private:
     struct Private;
     Private* const d;
--- trunk/koffice/libs/pigment/tests/CMakeLists.txt #1179887:1179888
@@ -101,3 +101,11 @@
 kde4_add_unit_test(TestKoColorSpaceSanity TESTNAME \
libs-pigment-TestKoColorSpaceSanity ${TestKoColorSpaceSanity_test_SRCS})  
 target_link_libraries(TestKoColorSpaceSanity  ${KDE4_KDEUI_LIBS} pigmentcms \
${QT_QTTEST_LIBRARY}) +
+########### next target ###############
+
+set(TestFallBackColorTransformation_test_SRCS TestFallBackColorTransformation.cpp )
+
+kde4_add_unit_test(TestFallBackColorTransformation TESTNAME \
libs-pigment-TestFallBackColorTransformation \
${TestFallBackColorTransformation_test_SRCS}) +
+target_link_libraries(TestFallBackColorTransformation  ${KDE4_KDEUI_LIBS} pigmentcms \
${QT_QTTEST_LIBRARY})


[prev in list] [next in list] [prev in thread] [next in thread]