[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/akonadi
From:       Bertjan Broeksema <broeksema () kde ! org>
Date:       2010-09-14 8:18:12
Message-ID: 201009141018.12737.broeksema () kde ! org
[Download RAW message or body]

On Monday 13 September 2010 08:54:22 Stephen Kelly wrote:
> SVN commit 1174657 by skelly:
> 
> Make the FavoriteCollectionsModel expose a list of Collection::Ids instead
> of Collections.
> 
> REVIEW: 5317
> 
>  M  +32 -24    favoritecollectionsmodel.cpp
>  M  +25 -0     favoritecollectionsmodel.h
> 
> 
> --- trunk/KDE/kdepimlibs/akonadi/favoritecollectionsmodel.cpp
> #1174656:1174657 @@ -40,13 +40,13 @@
>      {
>      }
> 
> -    QString labelForCollection( const Collection &collection )
> +    QString labelForCollection( const Collection::Id &collectionId )

If I'm correct, Collection::Id is an quint64. In that case it doesn't make 
much sense to pass it by reference.

Cheers,

Bertjan
[prev in list] [next in list] [prev in thread] [next in thread]