[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kate
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2010-09-03 21:08:41
Message-ID: 20100903210841.C0E23AC884 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1171431 by aacid:

const & in foreach


 M  +1 -1      completion/expandingtree/expandingwidgetmodel.cpp  
 M  +1 -1      completion/katecompletionwidget.cpp  
 M  +1 -1      syntax/katehighlighthelpers.cpp  
 M  +2 -2      utils/kateprinter.cpp  


--- trunk/KDE/kdelibs/kate/completion/expandingtree/expandingwidgetmodel.cpp \
#1171430:1171431 @@ -124,7 +124,7 @@
     
     clearMatchQualities();
     QMap<QModelIndex,ExpandingWidgetModel::ExpandingType> oldExpandState = \
                m_expandState;
-    foreach( QPointer<QWidget> widget, m_expandingWidgets )
+    foreach( const QPointer<QWidget> &widget, m_expandingWidgets )
       delete widget;
     m_expandingWidgets.clear();
     m_expandState.clear();
--- trunk/KDE/kdelibs/kate/completion/katecompletionwidget.cpp #1171430:1171431
@@ -865,7 +865,7 @@
 
     KTextEditor::MovingRange* ret = m_completionRanges.begin()->range;
     
-    foreach(CompletionRange range, m_completionRanges)
+    foreach(const CompletionRange &range, m_completionRanges)
       if(range.range->start() > ret->start())
         ret = range.range;
     return ret;
--- trunk/KDE/kdelibs/kate/syntax/katehighlighthelpers.cpp #1171430:1171431
@@ -278,7 +278,7 @@
 {
   alwaysStartEnable = false;
   customStartEnable = true;
-  foreach (QChar c, delims)
+  foreach (const QChar &c, delims)
     deliminators << c;
 }
 
--- trunk/KDE/kdelibs/kate/utils/kateprinter.cpp #1171430:1171431
@@ -498,7 +498,7 @@
           y += 1 + innerMargin;
 
           int _widest( 0 );
-          foreach (KateExtendedAttribute::Ptr attribute, _attributes)
+          foreach (const KateExtendedAttribute::Ptr &attribute, _attributes)
             _widest = \
qMax(QFontMetrics(attribute->font()).width(attribute->name().section(':',1,1)), \
_widest);  
           int _guideCols = _w/( _widest + innerMargin );
@@ -509,7 +509,7 @@
 
           _titleFont.setUnderline(true);
           QString _currentHlName;
-          foreach (KateExtendedAttribute::Ptr attribute, _attributes)
+          foreach (const KateExtendedAttribute::Ptr &attribute, _attributes)
           {
             QString _hl = attribute->name().section(':',0,0);
             QString _name = attribute->name().section(':',1,1);


[prev in list] [next in list] [prev in thread] [next in thread]