[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/krita
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2010-08-31 19:41:33
Message-ID: 20100831194133.B64B8AC879 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1170403 by rempt:

fix warnings

 M  +1 -1      image/tiles3/tests/kis_lockless_stack_test.cpp  
 M  +1 -1      plugins/extensions/dockers/colorselectorng/kis_color_selector_wheel.cpp \
  M  +1 -3      plugins/filters/phongbumpmap/phong_pixel_processor.cpp  
 M  +8 -4      plugins/filters/phongbumpmap/phongbumpmap.cpp  
 M  +1 -1      plugins/tools/defaulttools/kis_tool_colorpicker.cc  


--- trunk/koffice/krita/image/tiles3/tests/kis_lockless_stack_test.cpp \
#1170402:1170403 @@ -81,7 +81,7 @@
     }
 
     int pop() {
-        int value;
+        int value  = 0;
 
         bool result = m_stack.pop(value);
         Q_ASSERT(result);
--- trunk/koffice/krita/plugins/extensions/dockers/colorselectorng/kis_color_selector_wheel.cpp \
#1170402:1170403 @@ -32,7 +32,7 @@
 
 void KisColorSelectorWheel::setColor(const QColor &c)
 {
-    qreal angle, radius;
+    qreal angle = 0.0, radius = 0.0;
     angle = c.hueF();
     angle *= 2. * M_PI;
     angle -= M_PI;
--- trunk/koffice/krita/plugins/filters/phongbumpmap/phong_pixel_processor.cpp \
#1170402:1170403 @@ -103,7 +103,6 @@
 QRgb PhongPixelProcessor::testingSpeedIlluminatePixel(quint32 posup, quint32 \
posdown, quint32 posleft, quint32 posright)  {
     qreal temp;
-    qreal Il;
     quint8 channel = 0;
     const quint8 totalChannels = 3;
     qreal computation[] = {0, 0, 0};
@@ -179,7 +178,6 @@
 QRgb PhongPixelProcessor::reallyFastIlluminatePixel(quint32 posup, quint32 posdown, \
quint32 posleft, quint32 posright)  {
     qreal temp;
-    qreal Il;
     const int totalChannels = 3;
     qreal computation[] = {0, 0, 0};
     QColor pixelColor(0, 0, 0);
@@ -317,4 +315,4 @@
     pixelColor.setBlueF(computation[2]);
     
     return pixelColor;
-}
\ No newline at end of file
+}
--- trunk/koffice/krita/plugins/filters/phongbumpmap/phongbumpmap.cpp \
#1170402:1170403 @@ -102,9 +102,13 @@
                                     KisProcessingInformation dstInfo,
                                     const QSize& size,
                                     const KisFilterConfiguration* config,
-                                    KoUpdater* progressUpdater
+                                    KoUpdater* /*progressUpdater*/
                                     ) const
 {
+#ifdef __GNUC__
+    #warning TODO: implement progress updater for phong bumpmap
+#endif
+
     // Benchmark
     QTime timer, timerE;
     
@@ -120,7 +124,7 @@
     KisPaintDeviceSP src;
     src = srcInfo.paintDevice();
     
-    KoChannelInfo* m_heightChannel;
+    KoChannelInfo* m_heightChannel = 0;
     
     foreach (KoChannelInfo* channel, src->colorSpace()->channels()) {
         if (userChosenHeightChannel == channel->name())
@@ -352,12 +356,12 @@
     return config;
 }
 
-QRect KisFilterPhongBumpmap::neededRect(const QRect &rect, const \
KisFilterConfiguration* config) const +QRect KisFilterPhongBumpmap::neededRect(const \
QRect &rect, const KisFilterConfiguration* /*config*/) const  {
     return rect.adjusted(-2, -2, 2, 2);
 }
 
-QRect KisFilterPhongBumpmap::changedRect(const QRect &rect, const \
KisFilterConfiguration* config) const +QRect KisFilterPhongBumpmap::changedRect(const \
QRect &rect, const KisFilterConfiguration* /*config*/) const  {
     return rect.adjusted(-2, -2, 2, 2);
 }
--- trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc \
#1170402:1170403 @@ -198,7 +198,7 @@
     }
 }
 
-void KisToolColorPicker::mouseReleaseEvent(KoPointerEvent *event)
+void KisToolColorPicker::mouseReleaseEvent(KoPointerEvent */*event*/)
 {
     if (m_addPalette) {
         KoColorSetEntry ent;


[prev in list] [next in list] [prev in thread] [next in thread]