[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/kword/part/frames
From:       zander () kde ! org
Date:       2010-08-30 10:01:45
Message-ID: 201008301201.45655.zander () kde ! org
[Download RAW message or body]

On Monday 30. August 2010 11.50.17 Inge Wallin wrote:
>  And it was your patch that started the breakage if I 
> remember correctly.

You remember incorrectly. :)
Thats fine, really, just wanted to point out that the code as it is right now 
is how it has been for months until the unnamed induvidual changed it without 
review. I tried to make it so that it works for all cases, but without tests 
I'm just guessing.

> > I intend to get this to work correctly and that includes refactoring, if
> > your feature breaks because there are no unit tests, don't blame me
> > because I insisted on those being written a LOT of times.
> 
> Point taken; let's create some tests.
> 
> That said, I also think that if you know that a feature will break because
> of  your patch, it would be nice to put it up for review even if you are
> the maintainer.

As I said; I intend to get this to work correctly. As far as I know the 
feature didn't work before and is working a little better now.
And to be clear; as the maintainer I insist on unit tests to avoid depending 
on someone that wrote a feature to still be around later.
-- 
Thomas Zander
[prev in list] [next in list] [prev in thread] [next in thread]