[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/kword/part/frames
From:       zander () kde ! org
Date:       2010-08-30 9:04:10
Message-ID: 201008301104.10622.zander () kde ! org
[Download RAW message or body]

On Monday 30. August 2010 10.49.08 Inge Wallin wrote:
> On Sunday, August 29, 2010 23:02:38 Thomas Zander wrote:
> > SVN commit 1169681 by zander:
> > 
> > Revert "Revert commit 1158423"
> > 
> > This fixes crashes, so reinstating it as its known to work well.
> 
> > Conflicts:
> Sigh...
> 
> Instead of reverting the reverted reversions ad infinitum, could we perhaps
> have communication and end with a patch that solves *both* the crashes and
> the background image issues?

The background stuff was disabled by casper in rev 1161540, and even after 
asking again and again there are no unit tests that show how this feature is 
supposed to work (notice you can't enable this feature from the UI either).

Blaming the maintainer for maintaining the code and apparently blaming me for 
breaking your feature that didn't work anyway and was not made maintainable in 
the first place does give me the impression that, yes, we need communication. 
But not the kind that starts with "sigh" like your mail does..

I intend to get this to work correctly and that includes refactoring, if your 
feature breaks because there are no unit tests, don't blame me because I 
insisted on those being written a LOT of times.
-- 
Thomas Zander
[prev in list] [next in list] [prev in thread] [next in thread]