From kde-commits Sun Aug 29 20:13:58 2010 From: Amilcar do Carmo Lucas Date: Sun, 29 Aug 2010 20:13:58 +0000 To: kde-commits Subject: [kdevplatform] c681be5: Krazy fix Check single-char QString Message-Id: <201008292013.o7TKDwtb010776 () kore ! kollide ! net> X-MARC-Message: https://marc.info/?l=kde-commits&m=128311543700393 commit c681be566525dc3ab37f514e1a05619609ae2ec6 Author: Amilcar do Carmo Lucas Date: Tue Jun 2 22:21:00 2009 +0000 Krazy fix Check single-char QString operations for efficiency http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdevplatform/plugins/index.html diff --git a/gitplugin.cpp b/gitplugin.cpp index 03e40c1..dd9cc68 100644 --- a/gitplugin.cpp +++ b/gitplugin.cpp @@ -284,7 +284,7 @@ void GitPlugin::parseGitBlameOutput(DVcsJob *job) { QList results; int lineNumber = 0; QRegExp regex("(\\w{8}) \\((.*) (\\d+) [-+]\\d+\\s+\\d+\\)"); - foreach(QString line, job->output().split("\n")) { + foreach(QString line, job->output().split('\n')) { if (regex.indexIn(line) == 0) { VcsAnnotationLine annotation; annotation.setAuthor(regex.cap(2));