[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/filters/kpresenter/pptx
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2010-08-25 12:30:45
Message-ID: 20100825123045.967D0AC857 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1167822 by sebsauer:

Fix crash while opening the at the bugreport attached pptx-document by disabling the \
comments/notes-logic for now.

@Carlos
The reason for the crash is that we cannot use MsooXmlCommonReader(Methods|Impl).h \
and MsooXmlCommonReaderDrawingML(Methods|Impl).h more then in one class in a filter \
without earning a corrupted reader for whatever reason. The solution would be either \
to not use those shared functionality but to duplicate the code (that's how I solved \
it in the XlsxXmlWorksheet for now or, even better, look if we cannot just refactor \
that ugly code to have a proper base-class which can then be reused everywhere. The \
linked bug-report does also containt two patches demonstrating the problem/solution.

CC_MAIL:carlos_licea@hotmail.com
BUG:248991



 M  +2 -0      PptxXmlDocumentReader.cpp  


--- trunk/koffice/filters/kpresenter/pptx/PptxXmlDocumentReader.cpp #1167821:1167822
@@ -150,6 +150,7 @@
     }
 //! @todo expect other namespaces too...
 
+#if 0 // see bug #248991
     {
         PptxXmlCommentAuthorsReader autorsReader(this);
         const QString autorsFilePath = \
m_context->relationships->targetForType(m_context->path, m_context->file, \
MSOOXML::Relationships::commentAuthors); @@ -170,6 +171,7 @@
                                                                          \
                tableStylesFile, m_context->themes, d->tableStyleList);
         m_context->import->loadAndParseDocument(&tableStyleReader, \
tableStylesFilePath, &tableStyleReaderContext);  }
+#endif
 
     TRY_READ(presentation)
     kDebug() << "===========finished============";


[prev in list] [next in list] [prev in thread] [next in thread]