[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdegraphics/okular/ui
From:       Pino Toscano <pino () kde ! org>
Date:       2010-08-21 22:31:26
Message-ID: 20100821223126.69CF9AC857 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1166478 by pino:

fix the message displaying to work when the osd is disabled:
- really hide error messages, instead of show them after the proper message dialog box of the case
- if there are details, show a message box with details


 M  +6 -2      pageview.cpp  


--- trunk/KDE/kdegraphics/okular/ui/pageview.cpp #1166477:1166478
@@ -578,8 +578,12 @@
     if ( !Okular::Settings::showOSD() )
     {
         if (icon == PageViewMessage::Error)
+        {
+            if ( !details.isEmpty() )
+                KMessageBox::detailedError( this, message, details );
+            else
             KMessageBox::error( this, message );
-        else
+        }
             return;
     }
 
@@ -3254,7 +3258,7 @@
         verticalScrollBar()->setEnabled( true );
         horizontalScrollBar()->setEnabled( true );
         return;
-    }
+    }
 
     // move the viewport smoothly (kmplot: p(x)=1+0.47*(x-1)^3-0.25*(x-1)^4)
     float convergeSpeed = (float)diffTime / 667.0,
[prev in list] [next in list] [prev in thread] [next in thread]