[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/libs/kotext
From:       Thomas Zander <zander () kde ! org>
Date:       2010-08-20 12:57:42
Message-ID: 20100820130021.763F7AC855 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1165933 by zander:

Make pure virtual instead of empty

 M  +0 -5      KoInlineObject.cpp  
 M  +1 -1      KoInlineObject.h  
 M  +0 -5      KoVariable.cpp  
 M  +0 -11     KoVariable.h  


--- trunk/koffice/libs/kotext/KoInlineObject.cpp #1165932:1165933
@@ -74,11 +74,6 @@
     return d->manager;
 }
 
-void KoInlineObject::saveOdf(KoShapeSavingContext & context)
-{
-    Q_UNUSED(context);
-}
-
 void KoInlineObject::propertyChanged(Property key, const QVariant &value)
 {
     Q_UNUSED(key);
--- trunk/koffice/libs/kotext/KoInlineObject.h #1165932:1165933
@@ -118,7 +118,7 @@
      * Save this inlineObject as ODF
      * @param context the context for saving.
      */
-    virtual void saveOdf(KoShapeSavingContext &context);
+    virtual void saveOdf(KoShapeSavingContext &context) = 0;
 
     /**
      * Update position of the inline object.
--- trunk/koffice/libs/kotext/KoVariable.cpp #1165932:1165933
@@ -147,8 +147,3 @@
     Q_D(const KoVariable);
     return d->lastPositionInDocument;
 }
-
-bool KoVariable::loadOdf(const KoXmlElement&, KoShapeLoadingContext&)
-{
-    return true;
-}
--- trunk/koffice/libs/kotext/KoVariable.h #1165932:1165933
@@ -84,17 +84,6 @@
         return 0;
     }
 
-    /**
-     * Load a variable from odf.
-     * TODO make abstract when it is implemented in all variables
-     *
-     * @param element element which represents the shape in odf
-     * @param context the KoShapeLoadingContext used for loading
-     *
-     * @return false if loading failed
-     */
-    virtual bool loadOdf(const KoXmlElement &element, KoShapeLoadingContext &context);
-
 protected:
     /**
      * This hook is called whenever the variable gets a new position.
[prev in list] [next in list] [prev in thread] [next in thread]