[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/nepomuk/core
From:       Sebastian Trüg <trueg () kde ! org>
Date:       2010-08-16 11:27:42
Message-ID: 4C6920AE.5050900 () kde ! org
[Download RAW message or body]

On 08/16/2010 11:21 AM, Dirk Mueller wrote:
> SVN commit 1164224 by mueller:
> 
> I think a copy constructor should actually copy the
> same object,

no, it should not! Please revert. The idea is to be able to easily
convert them.

>  Nepomuk::File& Nepomuk::File::operator=( const KUrl& url )
>  {
> +    return (*this);
>  }

looks like I forgot to implement this one. And so did you. ;)
It should be: "return Resource::operator=(url);".

>  Nepomuk::File Nepomuk::Resource::toFile() const
>  {
> -    return File( *this );
> +    return File( resourceUri() );

what is this? This is a performance penalty! Instead of making use of
the implicit sharing you go through the whole process of looking up the
resource, querying its URI and so on!

please revert this one, too.

Cheers,
Sebastian
[prev in list] [next in list] [prev in thread] [next in thread]