[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kate/buffer
From:       Christoph Cullmann <cullmann () kde ! org>
Date:       2010-08-07 19:57:05
Message-ID: 20100807195705.13057AC7CA () svn ! kde ! org
[Download RAW message or body]

SVN commit 1160327 by cullmann:

myself:
    debug helper output, show me if a loading try with an encoding failed
    the bug 245334 is invalid
    if you try to open a file which is not utf-8 == contains invalid characters, the \
encoding detection will kick in  this is intended behaviour, else you can loose file \
content  while i can understand, that people might want to enforce an encoding even \
if it is wrong, if they have multiple encodings in one file, which is btw. no

CCBUG: 245334



 M  +3 -1      katetextbuffer.cpp  


--- trunk/KDE/kdelibs/kate/buffer/katetextbuffer.cpp #1160326:1160327
@@ -539,8 +539,10 @@
       encodingErrors = encodingErrors || currentError;
 
       // bail out on encoding error, if not last round!
-      if (encodingErrors && i < 3)
+      if (encodingErrors && i < 3) {
+        kDebug (13020) << "Failed try to load file" << filename << "with codec" << \
file.textCodec ()->name();  break;
+      }
 
       // get unicode data for this line
       const QChar *unicodeData = file.unicode () + offset;


[prev in list] [next in list] [prev in thread] [next in thread]