[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [Phonon] [BAD EMAIL] f8e430b: Fix uninitialized pointer.
From:       "Dr. Robert Marmorstein" <robert () narnia ! homeunix ! com>
Date:       2010-08-04 11:00:08
Message-ID: 201008041100.o74B08ZS020021 () kore ! kollide ! net
[Download RAW message or body]

commit f8e430b5b465919d8e58f77744ad058e4aa5ad1b
Author: Dr. Robert Marmorstein <robert@narnia.homeunix.com>
Date:   Tue Aug 3 23:45:09 2010 -0400

    Fix uninitialized pointer.
    
    BUG: 246087
    
    d_ptr->blah and d->blah are not the same in this case, because the Q_D
    macro was not used.  At least, I assume that's why it doesn't work.
    This fixes a crash in akregator (among other things).

diff --git a/phonon/videoplayer.cpp b/phonon/videoplayer.cpp
index 12835fb..b8038c9 100644
--- a/phonon/videoplayer.cpp
+++ b/phonon/videoplayer.cpp
@@ -88,7 +88,7 @@ VideoPlayer::VideoPlayer(QWidget *parent)
     : QWidget(parent)
     , d(new VideoPlayerPrivate)
 {
-    d_ptr->q_ptr = this;
+    d->q_ptr = this;
     d->category = Phonon::VideoCategory;
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]