[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/base/nepomuk-kde/backupsync/lib
From:       Vishesh Handa <handa.vish () gmail ! com>
Date:       2010-08-01 8:56:10
Message-ID: 20100801085610.2CAC6AC783 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1157856 by vhanda:

Renamed advancedIdentification to changeLogIdentification. Advanced Identification is a stupid name.


 M  +7 -8      identificationrequest_p.cpp  
 M  +5 -5      identificationrequest_p.h  


--- trunk/playground/base/nepomuk-kde/backupsync/lib/identificationrequest_p.cpp #1157855:1157856
@@ -123,10 +123,10 @@
 }
 
 
-void Nepomuk::Sync::IdentificationRequest::Private::loadAdvancedIdentificationHash()
+void Nepomuk::Sync::IdentificationRequest::Private::loadChangeLogHash()
 {
     // This function should only be called once, as it is quite an expensive affair
-    if( !m_advancedHash.isEmpty() )
+    if( !m_changeLogHash.isEmpty() )
         return;
     
     QList<ChangeLogRecord> records = m_masterChangeLog.toList();
@@ -151,7 +151,7 @@
         }
     }
     
-    m_advancedHash = convertToResourceHash( list );
+    m_changeLogHash = convertToResourceHash( list );
 }
 
 
@@ -164,7 +164,7 @@
     if( existsIdentify( uri ) )
         return true;
     
-    if( advancedIdentify( uri ) )
+    if( changeLogIdentify( uri ) )
         return true;
     
     if( addIdentify( uri ) )
@@ -352,15 +352,14 @@
 }
 
 
-bool Nepomuk::Sync::IdentificationRequest::Private::advancedIdentify( const QUrl& oldUri )
+bool Nepomuk::Sync::IdentificationRequest::Private::changeLogIdentify( const QUrl& oldUri )
 {
     if( m_hash.contains( oldUri ) )
         return true;
     
-    // Load the advanceHash
-    loadAdvancedIdentificationHash();
+    loadChangeLogHash();
 
-    const Sync::SimpleResource & res = m_advancedHash[ oldUri ];
+    const Sync::SimpleResource & res = m_changeLogHash[ oldUri ];
     QUrl resourceUri = findMatch( res );
 
     if( resourceUri.isEmpty() )
--- trunk/playground/base/nepomuk-kde/backupsync/lib/identificationrequest_p.h #1157855:1157856
@@ -72,8 +72,8 @@
             int m_id;
             static int NextId;
 
-            /// Used in advanced Identification
-            ResourceHash m_advancedHash;
+            /// Used in changeLog Identification
+            ResourceHash m_changeLogHash;
 
             /**
             * This contains all the urls that are being identified, at any moment.
@@ -87,7 +87,7 @@
             * Loading the advanced Identification hash is costly as the entire logfile
             * has to be parsed.
             */
-            void loadAdvancedIdentificationHash();
+            void loadChangeLogHash();
 
             //
             // Identification Procedures
@@ -115,10 +115,10 @@
 
             /**
             * A very imprecise identification process which probably doesn't work that well
-            * It uses the the previous values of identifyingProperty from the logfile
+            * It uses the the previous values of identifyingProperty from the ChangeLog
             * and uses them to find the resource.
             */
-            bool advancedIdentify( const QUrl& oldUri );
+            bool changeLogIdentify( const QUrl& oldUri );
 
             /**
             * Calls all the identification procedures one after another
[prev in list] [next in list] [prev in thread] [next in thread]