[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/kdm/backend
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2010-07-31 8:04:40
Message-ID: 20100731080440.A93DDAC7BC () svn ! kde ! org
[Download RAW message or body]

SVN commit 1157483 by ossi:

immediately close the pipe on error

that way cleanup paths can know that there is nothing to cleanup

 M  +3 -0      process.c  


--- trunk/KDE/kdebase/workspace/kdm/backend/process.c #1157482:1157483
@@ -558,6 +558,8 @@
 static void
 _gClosen(GPipe *pajp)
 {
+    if (pajp->fd.r == -1)
+        return;
     closeNclearCloseOnFork(pajp->fd.r);
 #ifndef SINGLE_PIPE
     closeNclearCloseOnFork(pajp->fd.w);
@@ -602,6 +604,7 @@
 static void ATTR_NORETURN
 gErr(void)
 {
+    gClosen(curtalk->pipe);
     Longjmp(curtalk->errjmp, 1);
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]