[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kfile
From:       Peter Penz <peter.penz19 () gmail ! com>
Date:       2010-07-27 6:58:56
Message-ID: 201007270858.56517.peter.penz19 () gmail ! com
[Download RAW message or body]

On Tuesday 27 July 2010 01:31:10 David Faure wrote:
> SVN commit 1155117 by dfaure:
> 
> Restore binary compatibility, which got broken in r1115714 (reviewboard
> 3613). /usr/lib/python2.6/site-packages/PyKDE4/kio.so: undefined symbol:
> _ZN13KUrlNavigator15keyReleaseEventEP9QKeyEvent CCMAIL:
> jjm@keelhaul.me.uk, peter.penz@gmx.at

Ah, I'm sorry for this. I checked 
http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#Adding_new_virtual_functions_to_leaf_classes \
 but missed the point that removing a virtual function is not allowed even it 
is a reimplementation from the base class.

The issue is also there on the 4.5 branch, I'll backport the fix today in the 
evening.

> M  +5 -0      kurlnavigator.cpp
> M  +5 -0      kurlnavigator.h
> 
> 
> --- trunk/KDE/kdelibs/kfile/kurlnavigator.cpp #1155116:1155117
> @@ -1095,6 +1095,11 @@
> }
> }
> 
> +void KUrlNavigator::keyReleaseEvent(QKeyEvent* event)
> +{
> +    QWidget::keyReleaseEvent(event);
> +}
> +
> void KUrlNavigator::mouseReleaseEvent(QMouseEvent* event)
> {
> if (event->button() == Qt::MidButton) {
> --- trunk/KDE/kdelibs/kfile/kurlnavigator.h #1155116:1155117
> @@ -428,6 +428,11 @@
> */
> virtual void keyPressEvent(QKeyEvent* event);
> 
> +    /**
> +     * Reimplemented for internal purposes
> +     */
> +    virtual void keyReleaseEvent(QKeyEvent* event);
> +
> /*
> * Paste the clipboard content as URL, if the middle mouse
> * button has been clicked.


[prev in list] [next in list] [prev in thread] [next in thread]