[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.5/kdelibs/kio/kio
From:       David Faure <faure () kde ! org>
Date:       2010-07-22 9:06:27
Message-ID: 20100722090627.882D3AC7AB () svn ! kde ! org
[Download RAW message or body]

SVN commit 1152979 by dfaure:

Fix passing false to QStrings (whoops) and fix a small related TODO.


 M  +6 -7      krun.cpp  


--- branches/KDE/4.5/kdelibs/kio/kio/krun.cpp #1152978:1152979
@@ -201,13 +201,12 @@
     KOpenWithDialog l(lst, i18n("Open with:"), QString(), window);
     if (l.exec()) {
         KService::Ptr service = l.service();
-        if (service) {
-            return KRun::run(*service, lst, window, tempFiles, suggestedFileName, \
                asn);
-        }
-
+        if (!service) {
         kDebug(7010) << "No service set, running " << l.text();
-        return KRun::run(l.text(), lst, window, false, suggestedFileName, asn);   // \
TODO handle tempFiles +            service = KService::Ptr(new KService(QString() \
/*name*/, l.text(), QString() /*icon*/));  }
+        return KRun::run(*service, lst, window, tempFiles, suggestedFileName, asn);
+    }
     return false;
 }
 
@@ -1155,13 +1154,13 @@
                 mimeTypeDetermined(KProtocolManager::defaultMimetype(d->m_strURL));
                 return;
             }
-            run(exec, urls, d->m_window, false, QString(), d->m_asn);
+            run(exec, urls, d->m_window, QString(), QString(), d->m_asn);
             ok = true;
         }
         else if (exec.startsWith('!')) {
             exec = exec.mid(1); // Literal command
             exec += " %u";
-            run(exec, urls, d->m_window, false, QString(), d->m_asn);
+            run(exec, urls, d->m_window, QString(), QString(), d->m_asn);
             ok = true;
         }
         else {


[prev in list] [next in list] [prev in thread] [next in thread]