[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdewebkit
From:       Dawit A <adawit () kde ! org>
Date:       2010-07-21 16:04:15
Message-ID: 201007211204.16305.adawit () kde ! org
[Download RAW message or body]

On Wednesday, July 21, 2010 06:11:42 André Wöbbeking wrote:
> On Wednesday 21 July 2010, Dawit Alemayehu wrote:
> > SVN commit 1152455 by
> 
> adawit:
> > Make the behavior of KWebWallet similar to other implementations by
> > requiring it to get confirmation before overwriting already cached
> > credentials.
> 
> > Now whenever a save request is going to overwrite an already
> > cached credential, KWebWallet will emit the saveFormDataRequested signal
> > and wait for the client to accept or decline the request instead of
> > blindingly overwriting the previous data.
> 
> > BUG:241118
> > 
> >  M  +33 -9
> 
>   kwebwallet.cpp
> 
> > --- trunk/KDE/kdelibs/kdewebkit/kwebwallet.cpp
> 
> #1152454:1152455
> 
> > @@ -108,6 +108,7 @@
> > 
> >      KWebWallet::WebFormList
> 
> pendingRemoveRequests;
> 
> >      QHash<KUrl, FormsData> pendingFillRequests;
> 
>   QHash<QString, KWebWallet::WebFormList> pendingSaveRequests;
> 
> > +
> 
> QHash<KUrl, bool> confirmSaveRequestOverwrites;
> 
> Wouldn't QSet<KUrl> be sufficient?

Indeed... changed. Thanks.

[prev in list] [next in list] [prev in thread] [next in thread]