[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/html
From:       Maks Orlovich <maksim () kde ! org>
Date:       2010-07-16 18:35:12
Message-ID: 20100716183512.75716AC73D () svn ! kde ! org
[Download RAW message or body]

SVN commit 1150788 by orlovich:

Merged revision:r1150787 | orlovich | 2010-07-16 14:32:15 -0400 (Fri, 16 Jul 2010) | 4 lines

Don't add an option to select's index on fastinsert path if the DOM addition failed.
Fixes crash on alitalia.com (reported on IRC)

 M  +1 -1      html_formimpl.cpp  


--- trunk/KDE/kdelibs/khtml/html/html_formimpl.cpp #1150787:1150788
@@ -2208,7 +2208,7 @@
 
     insertBefore(option, before, exceptioncode );
 
-    if (fastAppendLast) {
+    if (fastAppendLast && !exceptioncode) {
         m_listItems.resize(m_listItems.size() + 1);
         m_listItems[m_listItems.size() - 1] = option;
         ++m_length;
[prev in list] [next in list] [prev in thread] [next in thread]