[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/interfaces/ktexteditor
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2010-07-11 16:44:20
Message-ID: 201007111844.21120.dhdev () gmx ! de
[Download RAW message or body]

This was also backported to 4.5 branch, btw...

Dominik

On Samstag, 10. Juli 2010, David Nolden wrote:
> SVN commit 1148405 by zwabel:
> 
> Revert r1147043 (change default behavior of matchItem).
> This API exists for multiple minor revisions, and you cannot simply
> change the default-behavior and just update the comment, as that is not
> compatible, and will may cause random behavior changes when
> transitioning between 4.4 and 4.5. Please don't make the problem worse
> than it already is!
> CCMAIL: mail@milianw.de
> 
> 
>  M  +1 -1      codecompletionmodelcontrollerinterface.cpp
>  M  +1 -1      codecompletionmodelcontrollerinterface.h
> 
> 
> ---
> trunk/KDE/kdelibs/interfaces/ktexteditor/codecompletionmodelcontrollerin
> terface.cpp #1148404:1148405 @@ -109,7 +109,7 @@
> 
>  KTextEditor::CodeCompletionModelControllerInterface2::MatchReaction
> CodeCompletionModelControllerInterface2::matchingItem(const QModelIndex&
> selected) { Q_UNUSED(selected)
> -  return None;
> +  return HideListIfAutomaticInvocation;
>  }
> 
>  //END OLD
> ---
> trunk/KDE/kdelibs/interfaces/ktexteditor/codecompletionmodelcontrollerin
> terface.h #1148404:1148405 @@ -176,7 +176,7 @@
>      /**
>       * Called whenever an item in the completion-list perfectly matches
> the current filter text. * \param The index that is matched
> -     * \return Whether the completion-list should be hidden on this
> event. The default-implementation always returns None. +     * \return
> Whether the completion-list should be hidden on this event. The
> default-implementation always returns HideListIfAutomaticInvocation */
>      virtual MatchReaction matchingItem(const QModelIndex& matched);
>  };

[prev in list] [next in list] [prev in thread] [next in thread]