[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.5/kdeedu/marble/src/lib
From:       Bastian Holst <bastianholst () gmx ! de>
Date:       2010-07-11 10:21:22
Message-ID: 20100711102122.C37DFAC8A8 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1148629 by bholst:

Fixed Marble's wrong spinning direction.
The polarity is not an indicator for the visible pole.

CCBUG: 234861

backport of r1148621

 M  +3 -1      MarbleWidgetInputHandler.cpp  


--- branches/KDE/4.5/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp #1148628:1148629
@@ -511,12 +511,14 @@
                 // Choose spin direction by taking into account whether we
                 // drag above or below the visible pole.
                 if ( MarbleWidgetInputHandler::d->m_widget->projection() == Spherical ) {
-                    if ( polarity > 0 ) {
+                    if ( d->m_leftpressedb >= 0 ) {
+                        // The visible pole is the north pole
                         if ( event->y() < ( - MarbleWidgetInputHandler::d->m_widget->northPoleY()
                                             + MarbleWidgetInputHandler::d->m_widget->height() / 2 ) )
                             d->m_leftpresseddirection = -1;
                     }
                     else {
+                        // The visible pole is the south pole
                         if ( event->y() > ( + MarbleWidgetInputHandler::d->m_widget->northPoleY()
                                             + MarbleWidgetInputHandler::d->m_widget->height() / 2 ) )
                             d->m_leftpresseddirection = -1;
[prev in list] [next in list] [prev in thread] [next in thread]