[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [Amarok] 7920cd2: Move checking of bounded url into SqlTrack
From:       Nikolaj Hald Nielsen <nhnfreespirit () gmail ! com>
Date:       2010-06-04 9:25:22
Message-ID: AANLkTinZ48RHoAeMrr0f8XMMzWQYT4m4lZEnaTdzmoop () mail ! gmail ! com
[Download RAW message or body]

> This caused the regexp run every time a track is created/updated, and a
> noticeable performance hit when there are many tracks involved. Can the
> checks be moved out of SqlTrack?

Both you and Max are correct, and this should be cleaned up somehow.
My inital intention was just to get something into trunk that could be
tested and which was initially as un-intrusive as possible.

I will have a look at refactoring it. (if anyone has suggestions they
are more than welcome)

- Nikolaj
[prev in list] [next in list] [prev in thread] [next in thread]