[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/kchart
From:       Johannes Simon <johannes.simon () gmail ! com>
Date:       2010-06-03 8:36:23
Message-ID: 0658E112-B470-49E1-977D-75250B522C5E () gmail ! com
[Download RAW message or body]

The original crash has, if I understand correctly, been fixed by Sebastian, so leaving this in the code is done exclusively because it doesn't really make sense to draw a chart as tiny as that.
Am 02.06.2010 um 19:44 schrieb Inge Wallin:

> On Wednesday 02 June 2010 15:40:36 Sebastian Sauer wrote:
>> --- trunk/koffice/kchart/shape/PlotArea.cpp #1133790:1133791
>> @@ -1107,7 +1107,7 @@
>>     // Only paint the actual chart if there is a certain minimal size,
>>     // because otherwise kdchart will crash.
>>     QRect kdchartRect = ScreenConversions::scaleFromPtToPx(paintRect);
>> -    if (kdchartRect.width() > 20 && kdchartRect.height() > 20) {
>> +    if (kdchartRect.width() > 10 && kdchartRect.height() > 10) {
>>         d->kdChart->paint(&painter, kdchartRect);
>>     }
>>     //painter.restore();
> 
> Why did you change this?  I experimented a bit with the minimum size and I 
> managed to get crashes with 20. Note also that this fact is documented in the 
> comment above.


[prev in list] [next in list] [prev in thread] [next in thread]