[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kinit
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2010-05-31 21:34:33
Message-ID: 20100531213433.GA3171 () ugly ! local
[Download RAW message or body]

On Mon, May 31, 2010 at 07:23:36PM +0200, Luboš Luňák wrote:
> --- trunk/KDE/kdelibs/kinit/kinit.cpp #1132902:1132903
> +        if((i = display.lastIndexOf('.')) > display.lastIndexOf(':')
> && i >= 0)
>
i > foo already implies i>=0, as foo >= -1

> +        QString xauth = s_instance->dirs()->saveLocation( "tmp" ) + QLatin1String( "xauth-" )
> +            + QString::number( getuid()) + QLatin1String( "-" ) + QString::fromLocal8Bit( display );
>
given that this file is stored in the user's private temp dir, putting
the uid into it is pretty pointless (if it happens to be the invoking
user's private temp, then we'll have bigger problems sooner or later ..).

apart from that you'll get a krazy warning about the one-character
string.
[prev in list] [next in list] [prev in thread] [next in thread]