[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/filters/kword/docx
From:       "Lassi Nieminen" <lassniem () gmail ! com>
Date:       2010-05-31 16:19:27
Message-ID: 9D155021135E4BF3B5C23A6742A09AA5 () lassisof24c05a
[Download RAW message or body]

Yes, it was.
According to documentation t cannot be child of hyperlink.

--------------------------------------------------
From: "Inge Wallin" <inge@lysator.liu.se>
Sent: Monday, May 31, 2010 5:47 PM
To: <kde-commits@kde.org>; "Lassi Taneli Nieminen" <lassniem@gmail.com>
Subject: Re: koffice/filters/kword/docx

> On Monday 31 May 2010 15:03:04 Lassi Taneli Nieminen wrote:
>> SVN commit 1132801 by lassin:
>> 
>> Improved handling of bookmarks in docx.
>> 
>> 
>> 
>>  M  +167 -23   DocxXmlDocumentReader.cpp
>>  M  +5 -1      DocxXmlDocumentReader.h
>> 
>> 
>> --- trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.cpp
> 
>> +    m_closeHyperlink = true;
>> +
>>      while (!atEnd()) {
>>          readNext();
>>          if (isStartElement()) {
>> -            TRY_READ_IF(t)
> 
> Hmm, you removed reading of 't' here, was that conscious?
> 
>> -            ELSE_TRY_READ_IF(r)
>> +            TRY_READ_IF(r)
>>              ELSE_TRY_READ_IF(hyperlink)
>>              //! @todo add ELSE_WRONG_FORMAT
>>          }
>>          BREAK_IF_END_OF(CURRENT_EL)
>>      }
> 
[prev in list] [next in list] [prev in thread] [next in thread]