[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui/tests
From:       Stephen Kelly <steveire () gmail ! com>
Date:       2010-05-20 14:47:50
Message-ID: 20100520144750.3E833AC8BF () svn ! kde ! org
[Download RAW message or body]

SVN commit 1128874 by skelly:

Test that no signals are emitted when there is no selection.

 M  +15 -3     kselectionproxymodeltest.cpp  
 M  +0 -5      proxymodeltestsuite/proxymodeltest.h  


--- trunk/KDE/kdelibs/kdeui/tests/kselectionproxymodeltest.cpp #1128873:1128874
@@ -39,6 +39,18 @@
     : NoSelectionStrategy(proxyModelTest), m_proxyModelTest(proxyModelTest)
   { }
 
+  // If there is no selection, changes in the source model have no effect.
+  void noselection_testMoveData()
+  {
+    QTest::addColumn<SignalList>("signalList");
+    QTest::addColumn<PersistentChangeList>("changeList");
+    noopTest("move01");
+    noopTest("move02");
+    noopTest("move03");
+    noopTest("move04");
+    noopTest("move05");
+  }
+
   KSelectionProxyModel::FilterBehavior filterBehaviour() { return _filterBehaviour; }
 
   void testInsertWhenEmptyData() { noop_testInsertWhenEmptyData(); }
@@ -50,9 +62,9 @@
   void testRemoveFromTopLevelData() { noop_testRemoveFromTopLevelData(); }
   void testRemoveFromSecondLevelData() { noop_testRemoveFromSecondLevelData(); }
 
-  void testMoveFromRootData() { noop_testMoveFromRootData(); }
-  void testMoveFromTopLevelData() { noop_testMoveFromTopLevelData(); }
-  void testMoveFromSecondLevelData() { noop_testMoveFromSecondLevelData(); }
+  void testMoveFromRootData() { noselection_testMoveData(); }
+  void testMoveFromTopLevelData() { noselection_testMoveData(); }
+  void testMoveFromSecondLevelData() { noselection_testMoveData(); }
 
   void testModifyInRootData() { noop_testModifyInRootData(); }
   void testModifyInTopLevelData() { noop_testModifyInTopLevelData(); }
--- trunk/KDE/kdelibs/kdeui/tests/proxymodeltestsuite/proxymodeltest.h #1128873:1128874
@@ -547,11 +547,6 @@
     noopLayoutChangeTest("move03");
     noopLayoutChangeTest("move04");
     noopLayoutChangeTest("move05");
-//     noopTest("move01");
-//     noopTest("move02");
-//     noopTest("move03");
-//     noopTest("move04");
-//     noopTest("move05");
   }
 
   void noop_testMoveFromTopLevelData()
[prev in list] [next in list] [prev in thread] [next in thread]