[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui/itemviews
From:       Peter Penz <peter.penz () gmx ! at>
Date:       2010-05-19 16:52:18
Message-ID: 20100519165218.DAE2DAC8BA () svn ! kde ! org
[Download RAW message or body]

SVN commit 1128571 by ppenz:

Performance optimization: Check whether the categorization feature is used, before \
adjusting categorization specific properties

CCBUG: 237668

 M  +13 -2     kcategorizedview.cpp  


--- trunk/KDE/kdelibs/kdeui/itemviews/kcategorizedview.cpp #1128570:1128571
@@ -1329,7 +1329,7 @@
 
 void KCategorizedView::updateGeometries()
 {
-    const int verticalOff = verticalOffset();
+    const int oldVerticalOffset = verticalOffset();
 
     QListView::updateGeometries();
 
@@ -1371,7 +1371,7 @@
         verticalScrollBar()->setRange(0, bottomRange);
     } else {
         verticalScrollBar()->setRange(0, bottomRange);
-        verticalScrollBar()->setValue(verticalOff);
+        verticalScrollBar()->setValue(oldVerticalOffset);
     }
 
     //TODO: also consider working with the horizontal scroll bar. since at this \
level I am not still @@ -1391,6 +1391,9 @@
                                    const QModelIndex &bottomRight)
 {
     QListView::dataChanged(topLeft, bottomRight);
+    if (!d->isCategorized()) {
+        return;
+    }
 
     *d->hoveredBlock = Private::Block();
     d->hoveredCategory = QString();
@@ -1421,6 +1424,10 @@
                                     int end)
 {
     QListView::rowsInserted(parent, start, end);
+    if (!d->isCategorized()) {
+        return;
+    }
+
     *d->hoveredBlock = Private::Block();
     d->hoveredCategory = QString();
     d->rowsInserted(parent, start, end);
@@ -1446,6 +1453,10 @@
 
 void KCategorizedView::slotLayoutChanged()
 {
+    if (!d->isCategorized()) {
+        return;
+    }
+
     d->blocks.clear();
     *d->hoveredBlock = Private::Block();
     d->hoveredCategory = QString();


[prev in list] [next in list] [prev in thread] [next in thread]