[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/html
From:       Maks Orlovich <maksim () kde ! org>
Date:       2010-05-19 15:09:28
Message-ID: 20100519150928.29C2DAC8BA () svn ! kde ! org
[Download RAW message or body]

SVN commit 1128533 by orlovich:

Better add a null check here. Somehow this state can happen --- studying how, but extra paranoia won't
hurt. (Thanks to teve for reporting this)


 M  +1 -1      html_formimpl.cpp  


--- trunk/KDE/kdelibs/khtml/html/html_formimpl.cpp #1128532:1128533
@@ -2292,7 +2292,7 @@
     // element has an ID, we encoded it as iFoo.
     if (!multiple()) {
         HTMLOptionElementImpl* item = firstSelectedItem();
-        if (item->hasID())
+        if (item && item->hasID())
             return QString::fromLatin1("i") + item->getAttribute(ATTR_ID).string();
     }
 
[prev in list] [next in list] [prev in thread] [next in thread]