[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/libs/plasmagenericshell
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2010-05-06 18:54:46
Message-ID: 20100506185446.54B4FAC8AC () svn ! kde ! org
[Download RAW message or body]

SVN commit 1123740 by aseigo:

a few cleanups and safeties (particularly using value() instead of at())


 M  +7 -3      abstracticonlist.cpp  


--- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp #1123739:1123740
@@ -246,9 +246,10 @@
 {
     if (icon) {
         icon->collapse();
+    }
+
         m_currentAppearingAppletsOnList.removeAll(icon);
     }
-}
 
 //a faster way, given that we still need the visible-list
 void AbstractIconList::hideAllIcons()
@@ -440,7 +441,7 @@
     qreal list_size = listSize();
     qreal window_size = windowSize();
 
-    if (list_size <= window_size || m_currentAppearingAppletsOnList.count() == 0) {
+    if (list_size <= window_size || m_currentAppearingAppletsOnList.isEmpty()) {
         m_upLeftArrow->setEnabled(false);
         m_downRightArrow->setEnabled(false);
         m_upLeftArrow->setVisible(false);
@@ -498,7 +499,10 @@
 
 qreal AbstractIconList::itemPosition(int i)
 {
-    AbstractIcon *applet = m_currentAppearingAppletsOnList.at(i);
+    AbstractIcon *applet = m_currentAppearingAppletsOnList.value(i);
+    if (!applet) {
+        return 0;
+    }
 
     if (m_orientation == Qt::Horizontal) {
         return applet->pos().x();
[prev in list] [next in list] [prev in thread] [next in thread]