[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: koffice/krita/image/filter
From: Cyrille Berger <cberger () cberger ! net>
Date: 2010-05-05 21:26:24
Message-ID: 201005052326.25159.cberger () cberger ! net
[Download RAW message or body]
Hello,
I am confused by this change, why remove the bitBlt with selection ?
On Wednesday 05 May 2010, Dmitry Kazakov wrote:
> SVN commit 1123252 by dkazakov:
>
> Fixed a bug showing transparency on the bound of the image
>
> This was an old code. applicationRect != needRect. The filter will
> read from any source specified by needRect() just to ensure
> requestedRect is filtered successfully.
>
>
> M +3 -13 kis_filter_job.cpp
>
>
> --- trunk/koffice/krita/image/filter/kis_filter_job.cpp #1123251:1123252
> @@ -53,22 +53,12 @@
>
> void KisFilterJob::run()
> {
> - KisPaintDeviceSP dst = new KisPaintDevice(m_dev->colorSpace());
> - QRect marginRect = m_filter->neededRect(m_rc, m_config);
> -
> - m_filter->process(KisConstProcessingInformation(m_dev,
> marginRect.topLeft(), m_selection), -
> KisProcessingInformation(dst, marginRect.topLeft(), m_selection), -
> marginRect.size(),
> + m_filter->process(KisConstProcessingInformation(m_dev, m_rc.topLeft(),
> m_selection), + KisProcessingInformation(m_dev,
> m_rc.topLeft(), m_selection), + m_rc.size(),
> m_config,
> m_updater);
>
> - // blt back onto the original
> - KisPainter p2(m_dev);
> - p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_COPY));
> - p2.setSelection(m_selection);
> - p2.bitBlt(m_rc.topLeft(), dst, m_rc);
> - p2.end();
> -
> m_updater->setProgress(100);
> m_interrupted = m_updater->interrupted();
> }
--
Cyrille Berger
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic