[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/graphics/digikam/databaseserver
From:       Holger Foerster <hamsi2k () freenet ! de>
Date:       2010-05-04 11:10:49
Message-ID: 20100504111049.7CD20AC8AB () svn ! kde ! org
[Download RAW message or body]

SVN commit 1122630 by foerster:

Don't invent the wheel twice. Using of stringlist.join() instead of an own method.

 M  +1 -18     databaseserver.cpp  
 M  +0 -2      databaseserver.h  


--- trunk/extragear/graphics/digikam/databaseserver/databaseserver.cpp \
#1122629:1122630 @@ -326,7 +326,7 @@
 
     if ( !d->databaseProcess->waitForStarted() )
     {
-    	QString argumentStr = convertStringListToString(arguments, ", ");
+    	QString argumentStr = arguments.join(", ");
     	QString  str = i18n("Could not start database server!");
     	str+=i18n("<p>Executable: %1</p>", mysqldPath);
     	str+=i18n("<p>Arguments: %1</p>", argumentStr);
@@ -476,21 +476,4 @@
     return (d->databaseProcess->state() == QProcess::Running);
 }
 
-QString DatabaseServer::convertStringListToString(const QStringList &inputList, \
                const QString &delimiter)
-{
-	QString resultString;
-	QStringList::const_iterator iterator;
-	for (iterator = inputList.constBegin(); iterator != inputList.constEnd(); \
                ++iterator){
-		QString  entry 	= *iterator;
-		resultString.append(entry);
-
-		// Add a semicolon to the statement, if we are not on the last entry
-		if ((iterator+1) != inputList.constEnd())
-		{
-			resultString.append(delimiter);
-		}
-	}
-	return resultString;
-}
-
 } // namespace Digikam
--- trunk/extragear/graphics/digikam/databaseserver/databaseserver.h #1122629:1122630
@@ -55,8 +55,6 @@
     void startPolling();
     DatabaseServerError startMYSQLDatabaseProcess();
 
-    QString convertStringListToString(const QStringList &inputList, const QString \
                &delimiter);
-
 public Q_SLOTS:
     bool startDatabaseProcess(QString dbType, QDBusVariant &error);
     bool startDatabaseProcess(QDBusVariant &error);


[prev in list] [next in list] [prev in thread] [next in thread]