From kde-commits Sun May 02 18:26:29 2010 From: Maks Orlovich Date: Sun, 02 May 2010 18:26:29 +0000 To: kde-commits Subject: KDE/kdelibs/kjs Message-Id: <20100502182629.D608FAC8AA () svn ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=127282457516823 SVN commit 1121933 by orlovich: Remove an utterly stupid copy, and make 3d-morph 1.75x faster. (also ~4% speedup on SunSpider overall). Funny what profiling a slower test can show you.. M +2 -3 array_instance.cpp --- trunk/KDE/kdelibs/kjs/array_instance.cpp #1121932:1121933 @@ -444,9 +444,8 @@ } if (SparseArrayValueMap* map = storage->m_sparseValueMap) { - SparseArrayValueMap copy = *map; - SparseArrayValueMap::iterator end = copy.end(); - for (SparseArrayValueMap::iterator it = copy.begin(); it != end; ++it) { + SparseArrayValueMap::iterator end = map->end(); + for (SparseArrayValueMap::iterator it = map->begin(); it != end; ++it) { JSValue* value = it->second; if (!value->marked()) value->mark();