[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [Amarok] 2b5e3c0: EBN fixes: Use const references in foreach().
From:       Mark Kretschmann <kretschmann () kde ! org>
Date:       2010-04-17 11:30:03
Message-ID: 201004171130.o3HBU36R010167 () kore ! kollide ! net
[Download RAW message or body]

commit 2b5e3c0805b5703f11ed0f9ea75092ec551587ca
Author: Mark Kretschmann <kretschmann@kde.org>
Date:   Sat Apr 17 13:44:58 2010 +0200

    EBN fixes: Use const references in foreach().

diff --git a/src/App.cpp b/src/App.cpp
index 8df2001..6acac02 100644
--- a/src/App.cpp
+++ b/src/App.cpp
@@ -783,13 +783,12 @@ App::continueInit()
     QTimer::singleShot( 0, this, SLOT( checkCollectionScannerVersion() ) );
 
     //and now we can run any amarokurls provided on startup, as all components \
                should be initialized by now!
-    foreach( QString urlString, s_delayedAmarokUrls )
+    foreach( const QString& urlString, s_delayedAmarokUrls )
     {
         AmarokUrl aUrl( urlString );
         aUrl.run();
     }
     s_delayedAmarokUrls.clear();
-    
 }
 
 void App::checkCollectionScannerVersion()  // SLOT
diff --git a/src/browsers/filebrowser/FileView.cpp \
b/src/browsers/filebrowser/FileView.cpp index 2165645..1a912de 100644
--- a/src/browsers/filebrowser/FileView.cpp
+++ b/src/browsers/filebrowser/FileView.cpp
@@ -414,7 +414,7 @@ FileView::selectedItems() const
     if( indices.isEmpty() )
         return items;
 
-    foreach( QModelIndex index, indices )
+    foreach( const QModelIndex& index, indices )
     {
         KFileItem item = index.data( KDirModel::FileItemRole ).value<KFileItem>();
         items << item;
@@ -433,7 +433,7 @@ FileView::tracksForEdit() const
     if( indices.isEmpty() )
         return tracks;
 
-    foreach( QModelIndex index, indices )
+    foreach( const QModelIndex& index, indices )
     {
         KFileItem item = index.data( KDirModel::FileItemRole ).value<KFileItem>();
         Meta::TrackPtr track = CollectionManager::instance()->trackForUrl( \
item.url() ); @@ -469,7 +469,7 @@ FileView::slotDelete()
     
     QList<KUrl> urls;
 
-    foreach( QModelIndex index, indices )
+    foreach( const QModelIndex& index, indices )
     {
         KFileItem file = index.data( KDirModel::FileItemRole ).value<KFileItem>();
         debug() << "file path: " << file.url();
diff --git a/src/browsers/playlistbrowser/DynamicModel.cpp \
b/src/browsers/playlistbrowser/DynamicModel.cpp index a1c3b6d..aff85ba 100644
--- a/src/browsers/playlistbrowser/DynamicModel.cpp
+++ b/src/browsers/playlistbrowser/DynamicModel.cpp
@@ -588,7 +588,7 @@ PlaylistBrowserNS::DynamicModel::removeActive()
     QDomElement toRemove = m_playlistElements.takeAt( m_activePlaylist );
     m_playlistHash.remove( Dynamic::BiasedPlaylist::nameFromXml( toRemove ) );
     debug() << "size of m_playlistElements:" <<  m_playlistElements.size();
-    foreach( QDomElement e, m_playlistElements )
+    foreach( const QDomElement& e, m_playlistElements )
     {
         debug() << "m_playlistElements:" << e.attribute( "title" );
     }
diff --git a/src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp \
b/src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp index 86ac0c0..a6e1aab \
                100644
--- a/src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp
+++ b/src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp
@@ -168,7 +168,7 @@ PlaylistsByProviderProxy::dropMimeData( const QMimeData *data, \
Qt::DropAction ac  RoleVariantMap groupData =
                     m_groupMaps.value( parent.row() ).value( parent.column() );
             bool result = !originalIndexes.isEmpty();
-            foreach( QModelIndex originalIndex, originalIndexes )
+            foreach( const QModelIndex& originalIndex, originalIndexes )
             {
                 QModelIndex groupedColumnIndex =
                         originalIndex.sibling( originalIndex.row(), m_groupedColumn \
);


[prev in list] [next in list] [prev in thread] [next in thread]