[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.4/kdebase/apps/konsole/src
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2010-04-15 3:33:51
Message-ID: 20100415033351.F2B05AC898 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1114971 by hindenburg:

Don't crash when saving session data; don't use a reference to a freed object.

CCBUG: 232584


 M  +2 -2      SessionController.cpp  


--- branches/KDE/4.4/kdebase/apps/konsole/src/SessionController.cpp #1114970:1114971
@@ -1396,11 +1396,11 @@
         KMessageBox::sorry( 0 , i18n("A problem occurred when saving the \
output.\n%1",job->errorString()) );  }
 
-    SaveJob& info = _jobSession[job];
+    TerminalCharacterDecoder * decoder = _jobSession[job].decoder;
 
     _jobSession.remove(job);
 
-    delete info.decoder;
+    delete decoder;
 
     // notify the world that the task is done
     emit completed(true);


[prev in list] [next in list] [prev in thread] [next in thread]