[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/koffice-ko/kchart/shape
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2010-04-08 8:59:42
Message-ID: 201004081059.42211.inge () lysator ! liu ! se
[Download RAW message or body]

On Wednesday 07 April 2010 17:46:46 Sebastian Sauer wrote:
> SVN commit 1112207 by sebsauer:
> 
> Fix series counting which is 1-based
> 
>  M  +1 -1      DataSet.cpp
> 
> 
> --- branches/work/koffice-ko/kchart/shape/DataSet.cpp #1112206:1112207
> @@ -718,7 +718,7 @@
>          label += d->data( d->labelDataRegion, i ).toString();
> 
>      if ( label.isEmpty() )
> -        label = i18n( "Series %1", number() );
> +        label = i18n( "Series %1", number() + 1 );
> 
>      return QVariant( label );
>  }
> 

This is so clearly a bugfix.  Why not commit it to trunk instead?

I have asked boud to backport it now so don't do anything on it this time, but 
next time please commit bugfixes on trunk, ok?
[prev in list] [next in list] [prev in thread] [next in thread]