[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [Amarok] 5b29647: EngineController: Check m_currentTrack before usin
From:       Kelvie Wong <kelvie () ieee ! org>
Date:       2010-03-31 12:30:04
Message-ID: 201003311230.o2VCU4p6014647 () kore ! kollide ! net
[Download RAW message or body]

commit 5b29647fda026632554952d9c4ed2b4b207dddc7
Author: Kelvie Wong <kelvie@ieee.org>
Date:   Wed Mar 31 00:34:31 2010 -0700

    EngineController: Check m_currentTrack before using it.
    
    This seems to segfault for me when playing a cue track.

diff --git a/src/EngineController.cpp b/src/EngineController.cpp
index f7e1f65..009ecfd 100644
--- a/src/EngineController.cpp
+++ b/src/EngineController.cpp
@@ -1045,7 +1045,7 @@ EngineController::slotNewTrackPlaying( const Phonon::MediaSource &source )
     trackChangedNotify( m_currentTrack );
     newTrackPlaying();
 
-    if( !m_multiPlayback )
+    if( m_currentTrack && !m_multiPlayback )
     {
         m_media->blockSignals( true );
         m_media->setCurrentSource( m_currentTrack->playableUrl() );
[prev in list] [next in list] [prev in thread] [next in thread]