[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice
From:       Jarosław Staniek <staniek () kde ! org>
Date:       2010-03-30 9:26:11
Message-ID: 20100330092611.6E0F3AC889 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1108989 by staniek:

KoGenStyle(s) cleanup

* KoGenStyle::Type cleanup:
- renamed StyleUser to StyleParagraph
- renamed StyleAuto to StyleParagraphAuto
- move the 'Auto' to the end for the table style families
* KoGenStyles::Flags made QFlags                         
* KoGenStyles::lookup() -> KoGenStyles::insert()
* move KoGenStyle::isEmpty() code to .cpp
* use constFind(), constBegin(), constEnd() for iterators if possible
* made some methods const
* introduced KoGenStyles::StylesPlacement for saving odf and inserting raw styles.
* insertRawStyles() replaces 4 methods. saveOdfStyles() replaces 4 other methods.
* KoGenStyle::N_NumTypes -> KoGenStyle::N_NumPropertyTypes
* added KoGenStyle::N_NumTypes
* KoGenStyles: StyleArray -> QList<KoGenStyles::NamedStyle>
* KoGenStyles: NameMap typedef removed, using just QSet<QString> is clear
* To minimize size of the patch, I am noting down remaining possible TODOs:
* Implemented qDebug() for KoGenStyles instead of dump()
* Added KoGenStyles::FontFaceDecls to enum KoGenStyles::StylesPlacement, so
- removed void KoGenStyles::saveOdfFontFaceDecls(KoXmlWriter* xmlWriter) const; for \
                the same result use KoGenStyles::saveOdfStyles(FontFaceDecls, \
                xmlWriter)
- it's possible to add font faces using raw XML in insertRawOdfStyles()
- moved private methods to the Private class
* Added other proposed improvements
* Use Style and AutoStyle suffixes for Type enum
* Updated the whole koffice code for the KoGenStyle(s) change

Revieweing, testing:
*reviewed and approved by Jos; http://reviewboard.kde.org/r/3090/
*builds agains trunk, checked if there's no change in semantics, relevant unit tests \
                updated and passed
*while global search/replace was executed to port to the new API, the change has been \
reviewed line-by-line too



 M  +1 -1      filters/kpresenter/kpr2odf/Filterkpr2odf.cpp  
 M  +27 -27    filters/kpresenter/kpr2odf/StylesFilterkpr2odf.cpp  
 M  +6 -6      filters/kpresenter/powerpoint/DateTimeFormat.cpp  
 M  +66 -66    filters/kpresenter/powerpoint/PptToOdp.cpp  
 M  +5 -5      filters/kpresenter/powerpoint/globalobjectcollectors.h  
 M  +10 -8     filters/kpresenter/pptx/PptxImport.cpp  
 M  +2 -2      filters/kpresenter/pptx/PptxXmlSlideReader.cpp  
 M  +33 -33    filters/kspread/excel/import/excelimport.cc  
 M  +3 -3      filters/kspread/html/htmlimport.cc  
 M  +12 -12    filters/kspread/xlsx/ChartExport.cpp  
 M  +33 -33    filters/kspread/xlsx/NumberFormatParser.cpp  
 M  +7 -5      filters/kspread/xlsx/XlsxImport.cpp  
 M  +1 -1      filters/kspread/xlsx/XlsxXmlCommonReader.cpp  
 M  +3 -3      filters/kspread/xlsx/XlsxXmlDocumentReader.cpp  
 M  +1 -1      filters/kspread/xlsx/XlsxXmlSharedStringsReader.cpp  
 M  +14 -14    filters/kspread/xlsx/XlsxXmlWorksheetReader.cpp  
 M  +2 -1      filters/kword/docx/DocxImport.cpp  
 M  +9 -9      filters/kword/docx/DocxXmlDocumentReader.cpp  
 M  +1 -1      filters/kword/docx/DocxXmlFontTableReader.cpp  
 M  +10 -10    filters/kword/docx/DocxXmlStylesReader.cpp  
 M  +12 -12    filters/kword/kword1.3/import/kword13oasisgenerator.cpp  
 M  +18 -16    filters/kword/msword-odf/document.cpp  
 M  +6 -6      filters/kword/msword-odf/graphicshandler.cpp  
 M  +2 -2      filters/kword/msword-odf/mswordodfimport.cpp  
 M  +5 -5      filters/kword/msword-odf/paragraph.cpp  
 M  +9 -9      filters/kword/msword-odf/tablehandler.cpp  
 M  +7 -7      filters/kword/msword-odf/texthandler.cpp  
 M  +7 -7      filters/libmso/shapes.cpp  
 M  +2 -2      filters/libmsooxml/KoOdfExporter.cpp  
 M  +1 -1      filters/libmsooxml/MsooXmlCommonReader.cpp  
 M  +5 -5      filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h  
 M  +4 -4      karbon/common/KarbonDocument.cpp  
 M  +1 -1      kchart/KChartPart.cpp  
 M  +4 -4      kchart/shape/Axis.cpp  
 M  +1 -1      kchart/shape/ChartDocument.cpp  
 M  +2 -2      kchart/shape/ChartProxyModel.cpp  
 M  +3 -3      kchart/shape/ChartShape.cpp  
 M  +1 -1      kchart/shape/PlotArea.cpp  
 M  +2 -2      kchart/shape/Surface.cpp  
 M  +2 -2      kpresenter/part/KPrPlaceholderTextStrategy.cpp  
 M  +2 -2      kpresenter/part/pagelayout/KPrPageLayout.cpp  
 M  +4 -4      krita/ui/flake/kis_shape_layer.cc  
 M  +4 -4      krita/ui/flake/kis_shape_selection.cpp  
 M  +2 -2      kspread/Cell.cpp  
 M  +1 -1      kspread/GenValidationStyle.cpp  
 M  +1 -1      kspread/GenValidationStyle.h  
 M  +4 -4      kspread/Map.cpp  
 M  +8 -8      kspread/Sheet.cpp  
 M  +1 -1      kspread/SheetPrint.cpp  
 M  +12 -12    kspread/Style.cpp  
 M  +2 -2      kspread/StyleManager.cpp  
 M  +1 -1      kspread/part/Doc.cpp  
 M  +4 -4      kspread/shape/TableShape.cpp  
 M  +8 -8      kword/part/KWOdfWriter.cpp  
 M  +1 -1      libs/flake/KoDrag.cpp  
 M  +3 -3      libs/flake/KoPatternBackground.cpp  
 M  +3 -3      libs/flake/KoShape.cpp  
 M  +1 -1      libs/kopageapp/KoPADocument.cpp  
 M  +3 -3      libs/kopageapp/KoPAMasterPage.cpp  
 M  +3 -3      libs/kopageapp/KoPAPageBase.cpp  
 M  +1 -1      libs/kotext/KoTextDrag.cpp  
 M  +12 -12    libs/kotext/opendocument/KoTextWriter.cpp  
 M  +1 -1      libs/kotext/opendocument/tests/TestLoading.cpp  
 M  +2 -2      libs/kotext/styles/KoParagraphStyle.cpp  
 M  +18 -18    libs/kotext/styles/KoStyleManager.cpp  
 M  +38 -27    libs/odf/KoGenStyle.cpp  
 M  +93 -76    libs/odf/KoGenStyle.h  
 M  +291 -231  libs/odf/KoGenStyles.cpp  
 M  +87 -101   libs/odf/KoGenStyles.h  
 M  +8 -8      libs/odf/KoOdfGraphicStyles.cpp  
 M  +16 -16    libs/odf/KoOdfNumberStyles.cpp  
 M  +3 -3      libs/odf/KoOdfStylesReader.cpp  
 M  +1 -1      libs/odf/KoOdfStylesReader.h  
 M  +1 -1      libs/odf/KoPageLayout.cpp  
 M  +54 -54    libs/odf/tests/TestKoGenStyles.cpp  


http://websvn.kde.org/?view=rev&revision=1108989


[prev in list] [next in list] [prev in thread] [next in thread]