[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.4/kdelibs/khtml/html
From:       Raphael Kubo da Costa <kubito () gmail ! com>
Date:       2010-03-14 17:42:49
Message-ID: 1268588569.655987.15902.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1103253 by rkcosta:

Backport r1103252.

Do not strip of simplify an <option>'s value.

Simplifying is simply wrong, and trimming isn't required by the spec,
so we just follow other engines' behaviour here.

CCBUG: 60867


 M  +2 -2      html_formimpl.cpp  


--- branches/KDE/4.4/kdelibs/khtml/html/html_formimpl.cpp #1103252:1103253
@@ -2429,7 +2429,7 @@
         HTMLOptionElementImpl* const option = static_cast<HTMLOptionElementImpl*>(items[0]);
         encoded_values += enc_name;
         if (option->value().isNull())
-            encoded_values += fixUpfromUnicode(codec, option->text().string().trimmed());
+            encoded_values += fixUpfromUnicode(codec, option->text().string());
         else
             encoded_values += fixUpfromUnicode(codec, option->value().string());
         successful = true;
@@ -2711,7 +2711,7 @@
     if ( !m_value.isNull() )
         return m_value;
     // Use the text if the value wasn't set.
-    return text().string().simplified();
+    return text().string();
 }
 
 void HTMLOptionElementImpl::setValue(DOMStringImpl* value)
[prev in list] [next in list] [prev in thread] [next in thread]