[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/plugins/textshape/tests
From:       Thomas Zander <zander () kde ! org>
Date:       2010-03-09 17:48:43
Message-ID: 201003091848.44365.zander () kde ! org
[Download RAW message or body]

On Tuesday 9. March 2010 18.03.21 Thorsten Zachmann wrote:
> On Tuesday 09 March 2010 16:54:30 Andreas Hartmetz wrote:
> > SVN commit 1101207 by ahartmetz:
> >
> > link with gold
> >
> >  M  +1 -1      CMakeLists.txt
> >
> >
> > --- trunk/koffice/plugins/textshape/tests/CMakeLists.txt #1101206:1101207
> > @@ -78,7 +78,7 @@
> >
> >
> >  kde4_add_unit_test(TestChangeListCommand TESTNAME
> > shapes-text-TestChangeListCommand ${TestChangeListCommand_test_SRCS})
> > -target_link_libraries(TestChangeListCommand ${EXTRA_LIBS} komain
> > ${QT_QTTEST_LIBRARY}) +target_link_libraries(TestChangeListCommand
> > ${EXTRA_LIBS} ${SOPRANO_LIBRARIES} komain ${QT_QTTEST_LIBRARY})
> >
> >  ########### next target ###############
> 
> This breaks linking when compiled without soprano support.

Next to that, the test doesn't use any soprano APIs or even classes that do. 
So if Gold thinks its needed, file a bugreport with Gold since its wrong.

-- 
Thomas Zander
[prev in list] [next in list] [prev in thread] [next in thread]