[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdeplasma-addons/applets/weather
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-03-09 16:22:03
Message-ID: 201003090822.12294.aseigo () kde ! org
[Download RAW message or body]

On March 9, 2010, Artur Duque de Souza wrote:
> SVN commit 1101192 by asouza:
> 
> Fix minimum size of weather plasmoid
> 
> There is no way to show all the information with a size smaller
> than the one that is not setted as minimum. This seems to be the
> best approach to fix this bug.
> 
> BUG:201154
> 
> 
>  M  +1 -0      weatherapplet.cpp
> 
> 
> --- trunk/KDE/kdeplasma-addons/applets/weather/weatherapplet.cpp
> #1101191:1101192 @@ -81,6 +81,7 @@
>  {
>      connect(Plasma::Theme::defaultTheme(), SIGNAL(themeChanged()), this,
> SLOT(reloadTheme())); m_graphicsWidget = new QGraphicsWidget(this);
> +    m_graphicsWidget->setMinimumSize(385, 285);

setting a hardcoded size doesn't look right; shouldn't it get this information 
from the size hint of the widget?

p.s. i don't think there's much value in spending time backporting these 
polishing fixes to the 4.4 branch, esp as there's a high chance that further 
work will be done. other than actual grave bugfixes (the modal dialog fix you 
made certainly fits that one, imho :) this work should probably stay in the 
devel branch for now.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
[prev in list] [next in list] [prev in thread] [next in thread]