[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.4/kdeplasma-addons/applets/weather
From:       Artur Duque de Souza <asouza () kde ! org>
Date:       2010-03-09 15:06:57
Message-ID: 1268147217.903479.22820.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 1101199 by asouza:

Change weather behavior when it doesnt find icon condition

The correct fix would be to show the bigger version of the current
day condition. It's coming after this one.

This is just polishing as showing an invalid icon in front of
the name of the city is just not good: ugly icon in the face of
the user and broken usability (hard to read the name of the city).
Polishing++

Backport to 4.4



 M  +4 -4      weatherapplet.cpp  


--- branches/KDE/4.4/kdeplasma-addons/applets/weather/weatherapplet.cpp #1101198:1101199
@@ -377,10 +377,10 @@
         m_courtesyLabel->setText(creditUrl);
     }
 
-    if (data["Condition Icon"].toString() == "N/A") {
-        m_currentIcon->setIcon(KIcon("weather-not-available"));
-        setPopupIcon("weather-not-available");
-    } else if (!isValidData(data["Condition Icon"]) || data["Condition Icon"].toString() == "N/U") {
+    if (!isValidData(data["Condition Icon"]) ||
+        data["Condition Icon"].toString() == "N/U" ||
+        data["Condition Icon"].toString() == "N/A" ||
+        data["Condition Icon"].toString() == "weather-none-available") {
         m_currentIcon->hide();
     } else {
         m_currentIcon->setIcon(KIcon(data["Condition Icon"].toString()));
[prev in list] [next in list] [prev in thread] [next in thread]